Issue844

Title option parser: avoid special-case code for plug-in types that support predefinition
Priority wish Status resolved
Superseder Nosy List cedric, jendrik, malte, patfer, salome
Assigned To patfer Keywords
Optional summary

Created on 2018-09-21.12:49:57 by malte, last changed by jendrik.

Messages
msg8308 (view) Author: jendrik Date: 2018-12-13.22:34:29
I took care of the comments and merged. Thanks, Patrick, for enduring all of my
comments :-)
msg8297 (view) Author: malte Date: 2018-12-13.18:50:24
I had a look and left some final comments.
msg8288 (view) Author: jendrik Date: 2018-12-13.15:07:25
Patrick, Cedric and I are happy with the patch now. Malte, are you fine with the
changes (especially outside the option parser code)?
msg8241 (view) Author: malte Date: 2018-12-11.17:34:48
I left a few more comments. As usual, I'm more picky with the code outside the
option parser, but I think one of them looks like a genuine bug.
msg8237 (view) Author: jendrik Date: 2018-12-11.17:20:34
Great! From my point of view, this can be merged.
msg8233 (view) Author: patfer Date: 2018-12-11.15:45:24
I incorporated the more comments
msg8231 (view) Author: jendrik Date: 2018-12-11.15:11:34
I left some more comments on Bitbucket.
msg8191 (view) Author: patfer Date: 2018-12-07.18:09:03
Comments incorporated
msg8182 (view) Author: jendrik Date: 2018-12-07.15:03:06
I left some comments on Bitbucket.
msg8162 (view) Author: patfer Date: 2018-12-06.11:13:24
The PR can be reviewed under:
https://bitbucket.org/PatFer/downward/pull-requests/11/issue844/diff
msg7728 (view) Author: malte Date: 2018-09-21.12:49:57
Whether or not a plug-in type supports predefinition and what the associated
command-line option is should be controlled by the user of the option parser,
i.e., by the PluginTypePlugin, not in the option parser code.

Parts of meta-issue issue588.
History
Date User Action Args
2018-12-13 22:34:29jendriksetstatus: reviewing -> resolved
messages: + msg8308
2018-12-13 18:50:24maltesetmessages: + msg8297
2018-12-13 15:07:25jendriksetmessages: + msg8288
2018-12-11 17:34:48maltesetmessages: + msg8241
2018-12-11 17:20:34jendriksetmessages: + msg8237
2018-12-11 15:45:24patfersetmessages: + msg8233
2018-12-11 15:11:34jendriksetmessages: + msg8231
2018-12-07 18:09:03patfersetmessages: + msg8191
2018-12-07 15:03:06jendriksetmessages: + msg8182
2018-12-06 11:14:30patfersetassignedto: patfer
2018-12-06 11:13:24patfersetstatus: chatting -> reviewing
messages: + msg8162
2018-09-21 15:47:32cedricsetnosy: + cedric
2018-09-21 12:51:05jendriksetnosy: + jendrik
2018-09-21 12:49:57maltecreate