Issue864

Title let driver delete intermediate file
Priority wish Status resolved
Superseder Nosy List cedric, jendrik, malte
Assigned To jendrik Keywords driver
Optional summary
See also issue569 when working on this.

Created on 2018-11-05.13:14:25 by jendrik, last changed by jendrik.

Summary
See also issue569 when working on this.
Messages
msg8200 (view) Author: jendrik Date: 2018-12-08.12:55:51
I took care of the comments and merged.
msg8198 (view) Author: malte Date: 2018-12-08.11:54:31
I left some comments on bitbucket.
msg8197 (view) Author: jendrik Date: 2018-12-08.11:43:55
I updated the pull request. It is ready for review again.
msg8189 (view) Author: malte Date: 2018-12-07.17:29:51
As discussed offline, we should make sure this behaves as we would like it to
when no component selection options are specified are on the command line, but
the input file given is a SAS file. In this case we only run search, and we
shouldn't delete the input file.

Jendrik, please let me know once this is ready for review again. (Perhaps this
case is already handled correctly and it is already ready.)
msg8176 (view) Author: jendrik Date: 2018-12-07.09:05:45
I updated the patch accordingly.
msg8164 (view) Author: malte Date: 2018-12-06.12:29:44
In a live discussion, I suggested some changes to the documentation and to the
details of the defaults.
msg8161 (view) Author: jendrik Date: 2018-12-05.23:18:14
I made a pull request for this at https://bitbucket.org/jendrikseipp/downward/pull-requests/110 .
msg8160 (view) Author: jendrik Date: 2018-12-05.22:13:28
> To be clear, currently lab does not read output.sas for any of the property parsing?

No, it doesn't.
msg8058 (view) Author: malte Date: 2018-11-06.01:21:26
Added cross-reference to issue569.
msg8056 (view) Author: malte Date: 2018-11-06.01:19:55
Sounds good to me. If the default behaviour is for the driver to delete the
file, then I think there should be an option to keep the file around.

> However, I think this functionality belongs into the driver, since external
> tools like Lab should not have to know about internals like the translator
> output filename.

I'm not 100% convinced by that argument. I think it's normal that a program (in
this case Fast Downward) produces output files, and I think it's normal that an
experiment framework might need to have a look into these output files (and
decide whether or not to keep them around). This applies both to output.sas and
the plan files that the planner produces.

But independently of this line of reasoning, I agree that it makes sense to be
able to control in the driver whether or not the output.sas file is kept.

To be clear, currently lab does not read output.sas for any of the property parsing?
msg8052 (view) Author: jendrik Date: 2018-11-05.13:14:25
Currently, Lab deletes the "output.sas" file after running the driver. However, I 
think this functionality belongs into the driver, since external tools like Lab 
should not have to know about internals like the translator output filename.

I propose to let the driver delete "output.sas" when the search component finishes. 
If only the translator is run or when the soon-to-be-merged --translator-output-file 
option is used, the output file should not be deleted.

This is related to the idea of pipelining the translator output to the search (see 
issue569), where we also wouldn't have an intermediate file after the driver exits.
History
Date User Action Args
2018-12-08 12:55:51jendriksetstatus: reviewing -> resolved
messages: + msg8200
2018-12-08 11:54:31maltesetmessages: + msg8198
2018-12-08 11:43:55jendriksetmessages: + msg8197
2018-12-07 17:29:51maltesetmessages: + msg8189
2018-12-07 09:05:45jendriksetmessages: + msg8176
2018-12-06 12:29:44maltesetmessages: + msg8164
2018-12-05 23:18:14jendriksetstatus: chatting -> reviewing
messages: + msg8161
2018-12-05 22:13:28jendriksetmessages: + msg8160
2018-12-05 22:11:28jendriksetassignedto: jendrik
2018-11-06 01:21:26maltesetmessages: + msg8058
summary: See also issue569 when working on this.
2018-11-06 01:19:55maltesetstatus: unread -> chatting
messages: + msg8056
2018-11-05 14:02:55cedricsetnosy: + cedric
2018-11-05 13:14:25jendrikcreate