Issue911

Title Do not store TaskProxy in Pattern(Collection)Information
Priority wish Status reviewing
Superseder Nosy List florian, jendrik, malte, silvan
Assigned To silvan Keywords
Optional summary
Pull request: https://github.com/aibasel/downward/pull/10

Created on 2019-03-21.16:19:41 by silvan, last changed by florian.

Summary
Pull request: https://github.com/aibasel/downward/pull/10
Messages
msg11655 (view) Author: florian Date: 2024-07-19.13:42:54
Sorry my comment about the pull requests looking swapped is incorrect. Actually both pull requests (9 and 10) remove the task proxy and don't have other changes.
msg11653 (view) Author: florian Date: 2024-07-19.13:33:56
We had a look at this issue and pull request while triaging pull requests.

It looks like the pull requests for this issue (https://github.com/aibasel/downward/pull/10) and the one for issue906 (https://github.com/aibasel/downward/pull/9) were swapped, since pull request #9 is the one actually removing the TaskProxy.

To me, the open question is still what Malte said in msg8734: do we actually want to go in this direction? Not storing the TaskProxy together with the PDBs means that the caller has to know where the PDBs come from and make sure to not use the wrong task when accessing them.

Silvan, do you still want to push this? If so, can you add some arguments about why we should move in this direction? If this issue is just a prerequisite for issue906, maybe we should continue the discussion there.
msg8736 (view) Author: jendrik Date: 2019-03-21.16:50:18
I had the same question. Maybe this needs another offline discussion before we
act here.
msg8735 (view) Author: silvan Date: 2019-03-21.16:42:14
I understand this concern. We could also not do this here but in issue906, at
the cost of a larger diff that would possibly be reviewed/tested only at the
next sprint (would also be fine with me).
msg8734 (view) Author: malte Date: 2019-03-21.16:40:45
I had a quick look. My only question is whether this change actually goes into
the direction we want. I'm not saying it doesn't, but I'm not sure if we already
have a clear plan what the eventual data organization between these classes
should be. So I want to avoid a scenario where we change things back and forth.
msg8732 (view) Author: jendrik Date: 2019-03-21.16:36:16
I'll have a look.
msg8731 (view) Author: silvan Date: 2019-03-21.16:34:23
I opened a pull-request here:
https://bitbucket.org/SilvanS/fd-dev/pull-requests/47/issue911/diff
msg8726 (view) Author: silvan Date: 2019-03-21.16:19:40
As another preparation for issue906, where we would like to keep PDBs and their
patterns at the same place in PatternCollectionInformation, using
PatternInformation objects, we should get rid of task proxies that are currently
stored there just for commodity. Since this induces a diff at many files, I'd
like to do this here in a separate step.
History
Date User Action Args
2024-07-19 13:42:54floriansetmessages: + msg11655
2024-07-19 13:33:56floriansetnosy: + florian
messages: + msg11653
2020-07-24 11:29:39silvansetsummary: Pull request: https://github.com/aibasel/downward/pull/10
2019-03-21 16:50:18jendriksetmessages: + msg8736
2019-03-21 16:42:14silvansetmessages: + msg8735
2019-03-21 16:40:45maltesetmessages: + msg8734
2019-03-21 16:36:16jendriksetmessages: + msg8732
2019-03-21 16:34:23silvansetstatus: chatting -> reviewing
messages: + msg8731
2019-03-21 16:19:41silvancreate