Issue952

Title Change buildbot to use git repo
Priority feature Status resolved
Superseder Nosy List cedric, florian, jendrik, malte, patfer, silvan
Assigned To florian Keywords
Optional summary
TODO:
* ~~Don't set up "hg uncrustify" in workers.~~
* ~~rebuild workers~~
* ~~test forced build~~
* ~~test automated build~~
* ~~build only on main branch~~

Created on 2019-12-19.16:49:12 by patfer, last changed by malte.

Summary
TODO:
* Don't set up "hg uncrustify" in workers.
* rebuild workers
* test forced build
* test automated build
* build only on main branch
Messages
msg9575 (view) Author: malte Date: 2020-07-10.00:56:33
Yes, looks good. Thanks a lot!
msg9570 (view) Author: florian Date: 2020-07-09.19:53:21
The new filter worked out as expected. I think this finishes the issue.
msg9568 (view) Author: florian Date: 2020-07-09.17:46:10
I found a simple way to check for "[main]" in the commit message. I'll merge this issue to test it (I don't expect any more changes in the Fast Downward repository anyway).
msg9556 (view) Author: florian Date: 2020-07-09.14:07:20
All tests were successful except for nightly/weekly which depend on the change in the pull request below.

The remaining problem is that we set up the buildbot to test every commit on the branch "main" and in git this means "every commit reachable from the branch tip of main", so we end up testing all commits. Is it worth fixing this? Jendrik, Silvan, and Patrik are pushing hard for Github actions. If we switch to them soon, I don't want to waste too much time working on something that is deleted shortly after it is finished.
msg9540 (view) Author: florian Date: 2020-07-08.13:23:18
Forgot to add the link to the pull request:
https://github.com/FlorianPommerening/downward/pull/1/files
msg9539 (view) Author: florian Date: 2020-07-08.13:22:54
There are only two lines changing in the main repository but I set up a pull request anyway.

All other changes are in the infrastructure repository and are already live. I suggest to wait until some other issue is pushed to test this (issue976 sounds like a good candidate).
msg9400 (view) Author: florian Date: 2020-07-02.14:44:12
Good point, this occurs three times (searching for "default" in master.cfg finds the relevant parts).

We also have to adapt misc/buildbot/buildbot-exp.py to use the main branch and switch cached_revision.MERCURIAL to cached_revision.GIT.
msg9385 (view) Author: malte Date: 2020-07-01.18:37:11
I assume we will need to update the buildbot configuration to account for the new name of the main branch?
msg9373 (view) Author: florian Date: 2020-07-01.12:17:00
There were duplicated changes in the new branch and the default branch, so I closed/merged the new branch to reduce clutter.

We can do the final steps and test everything once the official git repo exists. Here is what is left to do for a test:

1. Adjust REPO_URL
   Currently it is set to  https://github.com/aibasel/git-downward.git
2. Push changes to aidev
   Currently aidev has some of the changes in the repo but the docker image was not rebuilt, so the  
   running version still uses mercurial.
3. Rebuild the docker image
   This is necessary, so git is installed instead of mercurial.
4. Reload master.cfg
   The config is in a docker volume, rebuilding might not update it. It might work but to be sure
   let's just reload the config anyway.
5. Test
   After pushing a commit to github, buildbot should automatically start building within 5 minutes.
msg9131 (view) Author: cedric Date: 2019-12-20.11:26:26
The changes for thew buildbot are in a separate branch in the infrastructure repository. I think they should work.

The problem that Patrick mentions here is that the buildbot workers try to update a mercurial repository since this is still on the buildbot. Maybe we missed something where mercurial is called explicitly or it is called via lab and there is detects that the local repository is still a mercurial repository.
msg9126 (view) Author: patfer Date: 2019-12-19.16:49:12
After sprint summary:

As we want to convert the fast downward repository to git, we have to change
this in the buildbot. Cedric and I started working on this, but at the end, it
did not work for some reasons. We have to finish this.
History
Date User Action Args
2020-07-10 00:56:33maltesetmessages: + msg9575
2020-07-09 19:53:22floriansetstatus: reviewing -> resolved
messages: + msg9570
summary: TODO: * ~~Don't set up "hg uncrustify" in workers.~~ * ~~rebuild workers~~ * ~~test forced build~~ * ~~test automated build~~ * build only on main branch -> TODO: * ~~Don't set up "hg uncrustify" in workers.~~ * ~~rebuild workers~~ * ~~test forced build~~ * ~~test automated build~~ * ~~build only on main branch~~
2020-07-09 17:46:10floriansetmessages: + msg9568
2020-07-09 14:07:20floriansetmessages: + msg9556
summary: TODO: * ~~Don't set up "hg uncrustify" in workers.~~ * rebuild workers * test forced build * test automated build -> TODO: * ~~Don't set up "hg uncrustify" in workers.~~ * ~~rebuild workers~~ * ~~test forced build~~ * ~~test automated build~~ * build only on main branch
2020-07-08 22:14:03floriansetsummary: TODO: * Don't set up "hg uncrustify" in workers. -> TODO: * ~~Don't set up "hg uncrustify" in workers.~~ * rebuild workers * test forced build * test automated build
2020-07-08 13:23:18floriansetmessages: + msg9540
2020-07-08 13:22:54floriansetstatus: chatting -> reviewing
assignedto: cedric -> florian
messages: + msg9539
2020-07-03 09:47:45jendriksetsummary: TODO: * Don't set up "hg uncrustify" in workers.
2020-07-02 14:44:12floriansetmessages: + msg9400
2020-07-01 18:37:11maltesetmessages: + msg9385
2020-07-01 12:17:00floriansetnosy: + florian
messages: + msg9373
2020-06-29 13:03:21maltesetpriority: critical -> feature
2019-12-20 11:26:26cedricsetstatus: unread -> chatting
messages: + msg9131
2019-12-19 16:49:12patfercreate