This is now merged.

Thanks! Yes, the run-clang-tidy.py comes bundled with clang-tidy. I searched for a different name for the new file, but the old one was just to good :-)

I also don't use this code and also don't know anything about it. I tried looking at the individual commits as Jendrik suggested. Looks like one file was removed in favor of a file that comes with clang-tidy (?) but then later another file was added with the same name as the removed file but a different content. It's hard to see in the diff but as long as it works I have no objections to merging this.

Florian, could you have a look at the code, please? The bulk of the diff stems from removing one file and putting code from another file in its place. It may be easiest to inspect the individual commits.

I don't really use this code and know nothing about it. Silvan wrote it's perhaps mainly moved code, but that doesn't seem to match the numbers in the diff (+132 lines, -431 lines). If Silvan doesn't want to sign off on the code, I suggest you ask Florian.

Malte, I also think that this doesn't necessarily need a review. Do you agree, or should I ask someone else for a review?

Sorry, I just needed to write an additional review for another ICAPS submission. I also wanted to read the reading group paper and urgently need to work on the paper for IJCAI. I don't think I can find the time to review this before the IJCAI deadline, because the PR is not small :-) 

Since I assume that this is pure refactoring and you only moved around code, I don't think we necessarily need a review here. The two new separate tests you extracted from the previous larger test look fine to me.

I'd like to finish this issue before working on issue958. Silvan, could you have a quick look at the patch, please?

Silvan, could you review the patch, please?

I prepared a pull request for this at https://bitbucket.org/jendrikseipp/downward/pull-requests/146 .

I'd like to separate the valgrind and clang-tidy tests into separate tox environments because they have additional non-Python dependencies and also run longer than most of our other tests.