Issue957

Title pass LP environment variables to tox build environments
Priority wish Status resolved
Superseder Nosy List cedric, florian, jendrik, malte
Assigned To jendrik Keywords
Optional summary

Created on 2020-01-16.09:18:08 by jendrik, last changed by jendrik.

Messages
msg9162 (view) Author: jendrik Date: 2020-01-16.13:57:29
I tested the patch locally, so I think it's fine to merge. Which I did now :-)
msg9161 (view) Author: florian Date: 2020-01-16.13:22:05
I also don't know anything about this code. I tried it yesterday for the first time and couldn't get it to work, so I'm not sure I'll be a better reviewer. But I have no objections to merging this.
msg9158 (view) Author: malte Date: 2020-01-16.12:26:35
Looks good to me, but I don't know much about this code. So perhaps ask Florian first if he's happy to see his merged.
msg9153 (view) Author: jendrik Date: 2020-01-16.10:30:07
Could someone have a look at the pull request, please?

https://bitbucket.org/jendrikseipp/downward/pull-requests/148
msg9152 (view) Author: jendrik Date: 2020-01-16.09:18:08
When setting up the tox environments, I forgot to pass the LP environment variables. Let's fix this in this issue.

Relevant docs: https://tox.readthedocs.io/en/latest/config.html#conf-passenv
History
Date User Action Args
2020-01-16 13:57:29jendriksetstatus: reviewing -> resolved
messages: + msg9162
2020-01-16 13:22:05floriansetmessages: + msg9161
2020-01-16 12:26:35maltesetmessages: + msg9158
2020-01-16 10:30:07jendriksetstatus: in-progress -> reviewing
messages: + msg9153
2020-01-16 10:20:27jendriksetstatus: unread -> in-progress
assignedto: jendrik
2020-01-16 09:24:24cedricsetnosy: + cedric
2020-01-16 09:18:08jendrikcreate