Issues Show Unassigned Show All Search
Login Remember me? Register Lost your login?
Help Roundup docs
Created on 2020-01-16.09:18:08 by jendrik, last changed by jendrik.
I tested the patch locally, so I think it's fine to merge. Which I did now :-)
I also don't know anything about this code. I tried it yesterday for the first time and couldn't get it to work, so I'm not sure I'll be a better reviewer. But I have no objections to merging this.
Looks good to me, but I don't know much about this code. So perhaps ask Florian first if he's happy to see his merged.
Could someone have a look at the pull request, please? https://bitbucket.org/jendrikseipp/downward/pull-requests/148
When setting up the tox environments, I forgot to pass the LP environment variables. Let's fix this in this issue. Relevant docs: https://tox.readthedocs.io/en/latest/config.html#conf-passenv