Title convert .hgignore to .gitignore
Priority feature Status resolved
Superseder Nosy List florian, jendrik, malte, patfer, silvan
Assigned To jendrik Keywords
Optional summary
part of issue954

Created on 2020-07-08.12:46:11 by jendrik, last changed by jendrik.

part of issue954
msg9555 (view) Author: jendrik Date: 2020-07-09.13:02:40
Sorry, we just merged this live via Zoom. The merge button works fine with our workflow if we remember to prepend "[main] " to the merge commit message.
msg9554 (view) Author: florian Date: 2020-07-09.12:45:30
If you are about to merge this, could you wait a little bit until I confirmed that the buildbot workers are running correctly? This way, we could also test issue952 at the same time.
msg9553 (view) Author: jendrik Date: 2020-07-09.12:36:14
msg9552 (view) Author: malte Date: 2020-07-09.12:33:54
Thanks, Jendrik! I would also ignore benchmark64, not just benchmark32. The way I read the Makefile and issues, both are meant to be created, it just requires some coaxing from the outside with environment variables, as in "make BITWIDTH=32 && make clean && make BITWIDTH=64" or whatever (didn't check the variable names and syntax).
msg9551 (view) Author: jendrik Date: 2020-07-09.12:29:29
I agree and moved the ignore patterns to the subdirectories.
msg9550 (view) Author: malte Date: 2020-07-09.12:08:25
I think the microbenchmark ignores don't make a lot of sense as global rules. Why do we need to enforce that these microbenchmarks are in a subdirectory of the relevant experiment directory? What if we want to do two microbenchmarks for a given issue? What if we want to do one but don't like plain Makefiles?

I think the rules are the way they are because that's what we needed for the first microbenchmark, and since then they have forced some of the other microbenchmarks into an awkward directory shape because we didn't like touching the .hgignore file for this because that's a fairly invasive change for "just" an experiment. But that reason doesn't apply in git, where we can simply put a .gitignore into the relevant experiment directory.

If you look at the five microbenchmarks we currently have, in three of them the "microbenchmark" directory is the *only* thing in the experiment directory, which doesn't make sense to me, and I would guess the only reason why this is the case is because we didn't want lots of different rules in .hgignore on a per-experiment basis.

I think a .gitignore file in the relevant benchmark directory with


would be better and would allow us more flexibility for future benchmarks.
msg9546 (view) Author: florian Date: 2020-07-08.19:13:44
Fine with me. If the merge doesn't match our workflow, it might be a bit messy to undo it but it should be possible. If it matches but only if you use the correct settings, we might want some protection against wrong configuration. But that discussion probably doesn't belong here. Maybe talk to Patrick as well, he is working on the push hooks in issue973.
msg9545 (view) Author: jendrik Date: 2020-07-08.17:09:41
I'm done with handling your comments. Can I merge this?

I'd use the GitHub merge UI to check whether we can make it confirm to our workflow.
msg9544 (view) Author: jendrik Date: 2020-07-08.13:49:48
Here you go:
msg9543 (view) Author: malte Date: 2020-07-08.13:48:28
Can you point us to a description of the .gitignore syntax?
msg9538 (view) Author: jendrik Date: 2020-07-08.13:07:45
Pull request:

Feel free to directly edit the .gitignore file on GitHub to save turnaround time.
Date User Action Args
2020-07-09 13:02:41jendriksetstatus: reviewing -> resolved
messages: + msg9555
2020-07-09 12:45:30floriansetmessages: + msg9554
2020-07-09 12:36:14jendriksetmessages: + msg9553
2020-07-09 12:33:54maltesetmessages: + msg9552
2020-07-09 12:29:29jendriksetmessages: + msg9551
2020-07-09 12:08:25maltesetmessages: + msg9550
2020-07-08 19:13:44floriansetmessages: + msg9546
2020-07-08 17:09:41jendriksetnosy: + silvan, florian, patfer
messages: + msg9545
2020-07-08 13:49:48jendriksetmessages: + msg9544
2020-07-08 13:48:28maltesetmessages: + msg9543
2020-07-08 13:07:45jendriksetstatus: unread -> reviewing
messages: + msg9538
2020-07-08 12:46:11jendrikcreate