Issue1081

Title Move error handling of options to the constructors
Priority wish Status resolved
Superseder Nosy List davidspeck, florian, jendrik, malte, silvan, simon
Assigned To Keywords
Optional summary
part of issue757

Created on 2023-02-09.14:19:44 by florian, last changed by simon.

Summary
part of issue757
Messages
msg11786 (view) Author: simon Date: 2025-02-13.15:48:20
We merged both to main \o/ 
thank you to all contributors.
msg11785 (view) Author: florian Date: 2025-02-12.09:19:19
I reviewed PR 245 and left some comments.
msg11782 (view) Author: simon Date: 2025-02-11.10:46:13
David and I worked on this issue and have a PR ready.
https://github.com/aibasel/downward/pull/245

Additionally, the context parameter is not used anymore in the create_component 
function. 
To remove this there is a second PR ontop (to make it easier to review)
https://github.com/SimonDold/downward/pull/7

Both are ready to review now.
msg10993 (view) Author: florian Date: 2023-02-09.14:19:44
When discussing the Python interface in issue757, we decided to move error-checking code that checks that the options passed to a component are consistent, into those components (for example checking that lists are non-empty, etc.). To still report the errors in the context in which they occurred, we want to throw an exception for errors and catch it in the calling code of the parser. We currently have two places where we generate warnings during parsing. If the change means that we can no longer generate them, we'll drop the possibility to generate warnings altogether. (The current warnings are not that important and we have similar places that do not generate warnings.)

The point of this is that if components are created without the parser (e.g., with the Python interface), they should also check those errors.
History
Date User Action Args
2025-02-13 15:48:20simonsetstatus: chatting -> resolved
messages: + msg11786
2025-02-12 09:19:19floriansetmessages: + msg11785
2025-02-11 10:46:14simonsetnosy: + simon, davidspeck
messages: + msg11782
2023-02-09 14:19:44floriancreate