Issue 1112: Add -Wzero-as-null-pointer-constant flag - Fast Downward issue tracker

Title	Add -Wzero-as-null-pointer-constant flag
Priority	wish	Status	resolved
Superseder		Nosy List	florian, jendrik, malte, silvan
Assigned To	florian	Keywords
Optional summary	Related to issue1107 and issue1096. Pull request: https://github.com/aibasel/downward/pull/177

Created on 2023-09-05.12:55:00 by florian, last changed by florian.

Summary
Related to issue1107 and issue1096. Pull request: https://github.com/aibasel/downward/pull/177

Messages
msg11342 (view)	Author: florian	Date: 2023-09-05.13:59:38
The tests were also successful, showing that all tested compilers support the flag. I merged the change.
msg11341 (view)	Author: malte	Date: 2023-09-05.13:30:20
Pull request looks good to me.
msg11340 (view)	Author: florian	Date: 2023-09-05.13:27:08
The warning triggered in some places including the SoPlex code. I fixed the places in our code and ignored the warning while importing SoPlex. The pull request is here: https://github.com/aibasel/downward/pull/177
msg11339 (view)	Author: malte	Date: 2023-09-05.13:11:32
Sounds like a good idea to me.
msg11338 (view)	Author: florian	Date: 2023-09-05.12:55:00
In issue1107 we found a useful check that is not enabled by "-Wall -Wextra -Wpedantic". It checks that 0 is not used in place of nullptr, which we want to do anyway.

History
Date	User	Action	Args
2023-09-05 13:59:38	florian	set	status: chatting -> resolved messages: + msg11342
2023-09-05 13:30:20	malte	set	messages: + msg11341
2023-09-05 13:27:08	florian	set	messages: + msg11340 summary: Related to issue1107 and issue1096. -> Related to issue1107 and issue1096. Pull request: https://github.com/aibasel/downward/pull/177
2023-09-05 13:11:32	malte	set	messages: + msg11339
2023-09-05 12:55:00	florian	create