Issue1191

Title M&S refactoring: have two variants of select_merge in MergeSelector
Priority wish Status resolved
Superseder Nosy List atorralba, jendrik, malte, silvan
Assigned To silvan Keywords
Optional summary

Created on 2025-09-18.16:54:56 by silvan, last changed by silvan.

Messages
msg11902 (view) Author: silvan Date: 2025-09-28.20:21:17
Merged.
msg11896 (view) Author: malte Date: 2025-09-19.16:03:39
If you tested it and are convinced it works as before, then from my side you can merge this.
msg11895 (view) Author: silvan Date: 2025-09-19.15:40:19
I prepared a pull-request: https://github.com/aibasel/downward/pull/275
Does this need an experiment?
msg11894 (view) Author: malte Date: 2025-09-18.19:41:02
Makes sense.
msg11893 (view) Author: silvan Date: 2025-09-18.16:54:56
As suggested in a code review for issue1171 by Álvaro (https://github.com/aibasel/downward/pull/244/files#r2275936695), I'd like to split the select_merge function of MergeSelector into two: one for the case that the caller provides a set of merge candidates, and one where they don't, in which case all pairs of factors are considered.
History
Date User Action Args
2025-09-28 20:21:17silvansetstatus: reviewing -> resolved
messages: + msg11902
2025-09-19 16:03:39maltesetmessages: + msg11896
2025-09-19 15:40:20silvansetstatus: chatting -> reviewing
nosy: + atorralba
messages: + msg11895
assignedto: silvan
2025-09-18 19:41:02maltesetstatus: unread -> chatting
messages: + msg11894
2025-09-18 16:54:56silvancreate