Issue134

Title boosting is not used in eager search
Priority wish Status resolved
Superseder Nosy List erez, gabi, malte
Assigned To erez Keywords
Optional summary

Created on 2010-10-25.10:21:18 by erez, last changed by malte.

Messages
msg832 (view) Author: malte Date: 2010-12-12.18:19:30
Thanks!
msg829 (view) Author: erez Date: 2010-12-12.12:21:28
I updated the documentation for alternation and for lazy search
msg799 (view) Author: malte Date: 2010-12-10.11:17:11
OK, changed and pushed to master. The value of 1000 in lazy was also used in two
places, so I've replaced it with a symbolic constant.

Can someone else update the documentation?
msg798 (view) Author: gabi Date: 2010-12-10.11:10:04
No objections. :-)
msg797 (view) Author: malte Date: 2010-12-10.10:45:51
Gabi, any objections?
msg796 (view) Author: erez Date: 2010-12-10.10:30:33
I've updated the documentation, but I agree with Malte about changing the default 
value of boost in alternation open list.
msg795 (view) Author: malte Date: 2010-12-10.08:58:43
Some comments on the docs:

 * The docs need not repeat the default if it's already given in the signature
   -- it's enough to maintain this in one place, otherwise this info tends to
   not get updated consistently.

 * There's a bug in one of the examples: the version where boost is not
   specified ("search h1=eval1 --search eager_greedy(h1, preferred=(h1))")
   is *not* equivalent to the following call that uses alt(), since eager_greedy
   has a default of 0 for boost, but alt has a default of 1000. Hence, in
   cases where no value is given, the value of 0 for alt would need to be
   given explicitly.

   That's a somewhat subtle and surprising issue, and I suggest to address that
   by changing the "boost" default of alt to 0 (while keeping the 1000 default
   of lazy_greedy).
msg794 (view) Author: malte Date: 2010-12-10.08:46:02
Committed this with two changes:
 * There was a comment adding that looked to be interrupted in the middle,
   so I completed it.
 * The default value for the eager boost was 1000, but it should be 0 as
   discussed below. Changed it to 0.

This is now in the master. Erez, can you add documentation for this for
eager_greedy and mark as resolved?
msg790 (view) Author: erez Date: 2010-12-08.08:46:01
This is now in issue134 in my repository
msg789 (view) Author: malte Date: 2010-12-08.00:46:02
This is not yet merged, right? I just checked your repository, and this is
tangled with all the problem adapter changes so that I cannot easily merge this.

Since this is a small change, it'd be good if this weren't held up until the
problem adapter is merged. Hence, the way forward would be for you to create a
new branch "issue134" off the current default branch and make the change there.

Alternatively, we can also wait with this until the problem adapter is
integrated, but that can take a while.
msg595 (view) Author: malte Date: 2010-10-25.16:30:33
Sure, I'll update this issue then and you'll get a notification. Could be a
while though; teaching started last week, things are a bit busy.
msg594 (view) Author: erez Date: 2010-10-25.16:26:41
Done.
Malte - let me know when you merge.
msg593 (view) Author: malte Date: 2010-10-25.16:13:02
If I understand these terms correctly, I'd go with "boost_preferred" always and
get rid of boost_last_used() -- this is what is described and evaluated in the
literature.

Extensions may be fine at a later point, but they should have a proven benefit.
Too many options is bad for maintenance.
msg592 (view) Author: erez Date: 2010-10-25.14:46:25
I changed the default value of boost to 0 in my repository.
Let me know when you merge this, and I'll update the wiki.
Also - I used boost_last_used(), while in lazy search we use boost_preferred().
Maybe we should make this a parameter?
msg591 (view) Author: malte Date: 2010-10-25.13:44:47
> I just noticed that boosting is not used at all with eager search.
> This is an easy fix, I'm just wondering if there's a reason it's not there.

Ask yourself, I think you implemented eager search. :-) (I originally only
implemented A*, for which there were neither boosting nor preferred operators
because we wanted it to be optimal.)

Boosting should be offered as an option for eager search, but according to the
ICAPS 2009 paper by Silvia and me, it should be off by default for eager search.
msg590 (view) Author: erez Date: 2010-10-25.10:25:35
The fix is available on my hg repository in Issue134 branch
msg589 (view) Author: erez Date: 2010-10-25.10:21:17
I just noticed that boosting is not used at all with eager search.
This is an easy fix, I'm just wondering if there's a reason it's not there.
History
Date User Action Args
2010-12-12 18:19:30maltesetstatus: chatting -> resolved
messages: + msg832
2010-12-12 12:21:28erezsetmessages: + msg829
2010-12-10 11:17:11maltesetmessages: + msg799
2010-12-10 11:10:04gabisetmessages: + msg798
2010-12-10 10:45:51maltesetmessages: + msg797
2010-12-10 10:30:33erezsetmessages: + msg796
2010-12-10 08:58:43maltesetstatus: resolved -> chatting
nosy: + gabi
messages: + msg795
2010-12-10 08:52:42erezsetstatus: reviewing -> resolved
2010-12-10 08:46:02maltesetmessages: + msg794
2010-12-08 08:46:01erezsetmessages: + msg790
2010-12-08 00:46:03maltesetmessages: + msg789
title: Boosting is not used in eager search -> boosting is not used in eager search
2010-10-25 16:30:33maltesetmessages: + msg595
2010-10-25 16:26:49erezsetstatus: chatting -> reviewing
2010-10-25 16:26:41erezsetmessages: + msg594
2010-10-25 16:13:02maltesetmessages: + msg593
2010-10-25 14:46:26erezsetmessages: + msg592
2010-10-25 13:44:47maltesetmessages: + msg591
2010-10-25 10:25:35erezsetmessages: + msg590
2010-10-25 10:21:18erezcreate