Issue149

Title Throw by value, catch by reference.
Priority wish Status resolved
Superseder Nosy List erez, gabi, malte
Assigned To gabi Keywords
Optional summary

Created on 2010-11-16.09:07:14 by erez, last changed by malte.

Messages
msg744 (view) Author: malte Date: 2010-11-22.20:47:17
Merged. Everyone, please note that the hg branch should have been called
"issue149", not "issue-149". Keeping this consistent will help with the
integration of hg, roundup, and rietveld.
msg739 (view) Author: malte Date: 2010-11-18.17:48:12
Looks good. There's not much to comment on in terms of code review. :-)
I'll merge when I'm back in Freiburg.
msg738 (view) Author: gabi Date: 2010-11-18.15:49:13
Ok, done. Malte, you can pull it from my repository (branch issue-149).

I also used this issue for a first test of the reviewing tool. You find the
changes at http://codereview.appspot.com/3202041.
msg734 (view) Author: gabi Date: 2010-11-16.13:23:55
Well, since I did it, I will change it.
msg733 (view) Author: malte Date: 2010-11-16.12:53:52
Adding Gabi to nosy since I think all throw/catch is in the option parser code.
msg732 (view) Author: erez Date: 2010-11-16.09:07:14
"Throw by value, catch by reference." (=> Sutter & Alexandrescu). 
So 
   catch (ParseError e)
should be 
   catch (ParseError &e)

I opened the issue - who's going to do it?
History
Date User Action Args
2010-11-22 20:47:18maltesetstatus: reviewing -> resolved
messages: + msg744
2010-11-18 17:48:12maltesetmessages: + msg739
2010-11-18 15:49:13gabisetstatus: chatting -> reviewing
messages: + msg738
2010-11-16 13:23:55gabisetassignedto: gabi
messages: + msg734
2010-11-16 12:53:52maltesetnosy: + gabi
messages: + msg733
2010-11-16 09:07:14erezcreate