Merged. Thanks Erez!

Jendrik - you should have read access now

Erez, can you give me access to your repo, please? Then I will merge the change.

Done

We have a function "exit_with" now that should be used instead (for more
consistent output). Can you change it to use this instead? Otherwise looks good
to me -- Florian or Jendrik, feel free to merge after the change if the diff
looks good to you, too.

Fix was pushed to my fixes repository: 
https://bitbucket.org/batman/downward-fixes
under branch
issue381


This is the diff of the change:

--- a/src/search/enforced_hill_climbing_search.cc       Tue Jun 11 12:47:36 2013 
+0200
+++ b/src/search/enforced_hill_climbing_search.cc       Mon Jun 17 16:00:12 2013 
+0300
@@ -65,12 +65,16 @@
 
     SearchNode node = search_space.get_node(current_state);
     evaluate(node.get_state(), NULL, node.get_state());
+    if (heuristic->is_dead_end()) {
+        cout << "Initial state is a dead end, no solution" << endl;
+        if (heuristic->dead_ends_are_reliable())
+            exit(EXIT_UNSOLVABLE);
+        else
+            exit(EXIT_UNSOLVED_INCOMPLETE);
+    }
+
     search_progress.get_initial_h_values();
 
-    if (heuristic->is_dead_end()) {
-        cout << "Initial state is a dead end, no solution" << endl;
-        return;
-    }
     current_h = heuristic->get_heuristic();
     node.open_initial(current_h);

I'll take care of this

This happens for example with

./plan ../benchmarks/mystery/prob07.pddl --search "ehc(ff())"

The output is

[...]
Conducting Enforced Hill Climbing Search
(real) g-bound = 2147483647
Initializing FF heuristic...
Initializing additive heuristic...
Simplifying 5268 unary operators... done! [5268 unary operators]
Initial state is a dead end, no solution
Peak memory: 8192 KB
caught signal 11 -- exiting
Running single search parser

Instead of crashing, the planner should return an exit code of 4
(EXIT_UNSOLVABLE) if the heuristic guarantees the dead end or 5
(EXIT_UNSOLVED_INCOMPLETE) if it does not.