Thanks again, Florian, for your extensive review of the CEGAR code. The easy
fixes have been applied already and the rest of the comments have been turned
into TODO items in the code that can be tackled after the merge.
One remaining issue is how to handle the dependency on boost::dynamic_bitset. As
far as I can see we have the following options:
A) Use "bcp" to find the headers required by dynamic_bitset.hpp and add them to
search/ext/boost (as done for any.hpp).
B) Make libboost-dev an external dependency.
C) Get rid of the dependency on dynamic_bitset.
I think C) should only be the last resort. If we go with B) we should later
remove the code from search/ext/boost. To evaluate option A) I have used bcp to
prepare subsets of boost that are required by any.hpp, dynamic_bitset.hpp and
both headers:
1,3M /home/jendrik/tmp/boost-1.45-any/boost
11M /home/jendrik/tmp/boost-1.45-both/boost
11M /home/jendrik/tmp/boost-1.45-dynamic_bitset/boost
1,5M /home/jendrik/tmp/boost-1.54-any/boost
3,8M /home/jendrik/tmp/boost-1.54-both/boost
3,7M /home/jendrik/tmp/boost-1.54-dynamic_bitset/boost
6,5M /home/jendrik/tmp/boost-1.60-any/boost
11M /home/jendrik/tmp/boost-1.60-both/boost
11M /home/jendrik/tmp/boost-1.60-dynamic_bitset/boost
boost-1.45 is the version that we currently include in our repo.
boost-1.54 is the boost version of the current Ubuntu LTS release (14.04).
boost-1.60 is the latest boost release.
Given these numbers, I don't think it's a good idea to add the additional boost
headers to our repo. Therefore, I would go with option B). What do you think?
|