We should change the text because there is no accompanying LICENSE_1_0.txt (and
I don't think we should add one). Having read the license, I think a simple way
to comply is to copy the license text itself into the source file, e.g. at the
top or bottom. I wouldn't want to do this with something heavy like the GPL, but
this one is short and simple, and I think it makes sense to have the licensing
terms right there.
Given that you substantially modified the code, we shouldn't just include the
old copyright notice there without further explanations, but I also wouldn't
want to add a detailed copyright statement of our own because we would have to
keep updating that in the future. Instead, I'd suggest something like:
/*
This source file was derived from the boost::any library version XYZ by XYZ.
Original copyright statement and license for this original source follow.
... [include stuff here]
*/
If we can find time, we can go over the code briefly in person. (I don't have
time to comment on bitbucket, which takes longer than discussing things live.)
But it looks good in general, so if it works, feel free to merge without further
review. One thing I noticed is some places with "0" instead of "nullptr".
|