Issue676

Title Clean up task usage in PDB code
Priority wish Status resolved
Superseder Nosy List florian, jendrik, malte
Assigned To florian Keywords
Optional summary
Split off from issue598

Created on 2016-09-28.21:25:14 by florian, last changed by florian.

Summary
Split off from issue598
Messages
msg5695 (view) Author: florian Date: 2016-09-29.12:19:13
Merged.
msg5694 (view) Author: malte Date: 2016-09-29.11:07:20
Fine with me.
msg5691 (view) Author: florian Date: 2016-09-29.09:39:13
With Jendrik's second review, can we merge this without experiments?
msg5689 (view) Author: jendrik Date: 2016-09-28.23:34:12
I had a look as well and everything looks good.
msg5685 (view) Author: malte Date: 2016-09-28.22:04:37
I looked at the code. this was well worth moving to a separate issue. I have no
further comments, but I cannot guarantee that I missed nothing, so if you want a
bit more certainty, we should either have experiments or someone else reviewing
the code.
msg5683 (view) Author: florian Date: 2016-09-28.21:44:02
I created a pull request for all of the changes from issue598 that we don't want to 
handle there:

https://bitbucket.org/FlorianPommerening/downward-issues/pull-
requests/24/issue676/diff
msg5682 (view) Author: florian Date: 2016-09-28.21:25:14
As a preparation for issue598, we want to bring the PDB up to date with our new 
guidelines on how and when to pass a task. This will also touch on some global 
classes that are used by the PDB code (SuccessorGenerator and VariableOrderFinder), 
but except for those, I'd like to limit the diff to the "pdbs" directory. We should 
think about creating similar issues for other parts of the code.
History
Date User Action Args
2016-09-29 12:19:13floriansetstatus: chatting -> resolved
messages: + msg5695
2016-09-29 11:07:20maltesetmessages: + msg5694
2016-09-29 09:39:13floriansetmessages: + msg5691
2016-09-28 23:34:12jendriksetmessages: + msg5689
2016-09-28 22:04:37maltesetmessages: + msg5685
2016-09-28 21:44:02floriansetmessages: + msg5683
2016-09-28 21:25:14floriancreate