Issue792

Title Get rid of g_successor_generator
Priority feature Status resolved
Superseder Nosy List florian, jendrik, malte
Assigned To florian Keywords
Optional summary
Part of issue509.

Created on 2018-06-04.17:55:54 by florian, last changed by florian.

Summary
Part of issue509.
Messages
msg7538 (view) Author: florian Date: 2018-09-18.19:01:23
Fantastic! Merged and pushed.
msg7537 (view) Author: malte Date: 2018-09-18.18:54:06
Yes, please!
msg7535 (view) Author: florian Date: 2018-09-18.18:50:34
The experiments for this one are done and it looks like nothing changed beyond
the usual noise (if anything, there is a small positive trend in total time):

http://ai.cs.unibas.ch/_tmp_files/pommeren/issue792-v1-opt-issue792-base-issue792-v1-compare.html

Can I merge this?
msg7527 (view) Author: malte Date: 2018-09-18.16:15:11
Done with my comments. All my comments are about the comments.
msg7502 (view) Author: jendrik Date: 2018-09-18.00:18:25
I'm done with this round of review.
msg7494 (view) Author: florian Date: 2018-09-17.17:55:02
I updated the pull request with the changes from issue774 and issue824.
msg7198 (view) Author: florian Date: 2018-06-05.11:56:58
Thanks Jendrik. I removed the old forward declaration and updated the pull request.
msg7183 (view) Author: jendrik Date: 2018-06-04.22:20:42
I only left one minor comment on Bitbucket. Otherwise, the code looks good to me.
msg7179 (view) Author: florian Date: 2018-06-04.20:17:23
The following pull request is against issue774 because it is easier to merge it
before we consider this issue.

https://bitbucket.org/FlorianPommerening/downward-issues/pull-requests/46
msg7171 (view) Author: florian Date: 2018-06-04.17:55:54
While moving to the new task interface, we want to get rid of the global
successor generator. Instead of having one global object, it should be created
from a task proxy.
History
Date User Action Args
2018-09-18 19:01:23floriansetstatus: reviewing -> resolved
messages: + msg7538
2018-09-18 18:54:06maltesetmessages: + msg7537
2018-09-18 18:50:34floriansetmessages: + msg7535
2018-09-18 16:15:11maltesetmessages: + msg7527
2018-09-18 00:18:25jendriksetmessages: + msg7502
2018-09-17 17:55:02floriansetstatus: in-progress -> reviewing
messages: + msg7494
2018-06-05 11:56:58floriansetmessages: + msg7198
2018-06-04 22:20:42jendriksetmessages: + msg7183
2018-06-04 20:17:23floriansetmessages: + msg7179
2018-06-04 17:55:54floriancreate